We're using cookies to make this site more secure, featureful and efficient.

Issue 2967: Date for Dance

Object
The Highland Lass (Dance)
Submitter
Mark Dancer (Aelfric)
Assigned to
Roland Telle
Priority
Normal
Disposition
Fixed
Description
'StateBlock' object has no attribute 'is_code_block'
Playford published two dances of this name. The instructions in Book 30 match the later, 1718 version.

Previous Actions

  • Date  Dec. 18, 2022, 6:04 a.m.
  • User  Mark Dancer (Aelfric)
'StateBlock' object has no attribute 'is_code_block'
New issue submitted
  • Date  Dec. 18, 2022, 11:41 a.m.
  • User  Roland Telle (Roland)
'StateBlock' object has no attribute 'is_code_block'
_Assigned_ changed to »Roland« (previously »None«)  
_Disposition_ changed to »Needs help« (previously »New«)  

Hi Mark,  

In Book 30, we read: Adapted from John Playford: *The Dancing Master, Volume the Second* Fourth
Edition, _1728_.  
Please can you check the date?  

Best regards  
Roland
  • Date  Dec. 18, 2022, 11:46 a.m.
  • User  Mark Dancer (Aelfric)
'StateBlock' object has no attribute 'is_code_block'
Hello Roland,

Well caught.

Oops, mea culpa.

1718 is what my brain said to type and what my fingers totally failed to produce.

BTW http://playforddances.com/dances-2-3/highland-lass-2/ was my reference.

Cheers,
Mark
  • Date  Dec. 18, 2022, 12:12 p.m.
  • User  Murrough Landon (murrough)
'StateBlock' object has no attribute 'is_code_block'
My conclusion from reading this is that we should use 1728 for this dance as in Book 30. But perhaps also make a note that there is another version from 1718 as mentioned in the playforddances.com website?
  • Date  Dec. 18, 2022, 12:22 p.m.
  • User  Roland Telle (Roland)
'StateBlock' object has no attribute 'is_code_block'
Hi Mark and Murrough,  

Hm! I tkink that Mark is right. _1728_ seems to be the Fourth Edition date of The Dancing Master Volume Two but according to Mark's reference, the date of the tune is 1718.  

IMO, Book 30 and Mark are correct.  
Any comment?  

Best regards  
Roland
  • Date  Dec. 18, 2022, 12:24 p.m.
  • User  Mark Dancer (Aelfric)
'StateBlock' object has no attribute 'is_code_block'
I'm wondering if it's a case of the person who did the dance for Book 30 had access to to 1728 edition, but not the 1718. The Playford dances in the database seem to only come from certain editions. But John Playford and his successors were rolling dances in and out of the editions over time, and a lot of the dances were introduced in editions from other years. I wrote some SQl to run against a local copy of the database some time ago, let me find it and it might explain the above a whole lot better.

  • Date  Dec. 18, 2022, 12:56 p.m.
  • User  Murrough Landon (murrough)
'StateBlock' object has no attribute 'is_code_block'
I am happy to go with the consensus. But whichever of the dates we assign the dance I suggest we just add an extra note summarising this discussion.
  • Date  Dec. 18, 2022, 1:41 p.m.
  • User  Roland Telle (Roland)
'StateBlock' object has no attribute 'is_code_block'
Hi Murrough,  

Yes. Please add the note as your English is probably better than mine :-)  

Thank you to Mark and Murrough!  

Best regards  
Roland
  • Date  Dec. 18, 2022, 1:51 p.m.
  • User  Mark Dancer (Aelfric)
'StateBlock' object has no attribute 'is_code_block'
OK, found the old mods I was running on my local copy of the database. (This hasn't been run for over 3 years, and I'd added some extra columns to some of the tables, so it doesn't match the database structure).

Here's the mods to the publications table so you can see what the changes were (for some reason the indexes didn't come down):

--
--  Publication
--

ALTER TABLE publication
   ADD      sort_name character varying(128);
UPDATE      publication
   SET      sort_name = name;

ALTER TABLE publication
   ADD      tag_id INTEGER;
	
CREATE      UNIQUE INDEX publication_pk
   ON       publication ( id );
CREATE      INDEX publication_devisor_fk
   ON       publication ( devisor_id );
CREATE      INDEX publication_tag_fk
   ON       publication ( tag_id );
CREATE      INDEX publication_name_ix
   ON       publication ( name );

Anyway, these are the entries for Playford that I was adding to match the dances by Playford and his successors, which I had extracted by going through an online source that lists every edition and the dances in that edition:

--
--  Playford's [English] Dancing Master
--

INSERT INTO publication
   VALUES   ( 50001, CURRENT_TIMESTAMP, NULL,
            'The English Dancing Master', 'Playford 1.01',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1651,
            'The English Dancing Master', NULL );

INSERT INTO publication
   VALUES   ( 50002, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 4th ed.', 'Playford 1.04',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1670,
            'The Dancing Master, 4th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50003, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 6th ed.', 'Playford 1.06',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1679,
            'The Dancing Master, 6th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50004, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 7th ed.', 'Playford 1.07',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1686,
            'The Dancing Master, 7th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50005, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 8th ed.', 'Playford 1.08',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1690,
            'The Dancing Master, 8th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50006, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 9th ed.', 'Playford 1.09',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1695,
            'The Dancing Master, 9th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50007, CURRENT_TIMESTAMP, NULL,
            'The Second Part of the Dancing-Master', 'Playford 1.09b',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1696,
            'The Second Part of the Dancing-Master', NULL );

INSERT INTO publication
   VALUES   ( 50008, CURRENT_TIMESTAMP, NULL,
            'An Additional Sheet of New Dances for the Second Part of the Country-Dancing-Master', 'Playford 1.09c',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1697,
            'An Additional Sheet of New Dances for the Second Part of the Country-Dancing-Master', NULL );

INSERT INTO publication
   VALUES   ( 50009, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 10th ed.', 'Playford 1.10',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1698,
            'The Dancing Master, 10th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50011, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 11th ed.', 'Playford 1.11',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1701,
            'The Dancing Master, 11th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50012, CURRENT_TIMESTAMP, NULL,
            'New Country Dances', 'Playford 1.11b',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1701,
            'New Country Dances', NULL );

INSERT INTO publication
   VALUES   ( 50013, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 12th ed.', 'Playford 1.12',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1703,
            'The Dancing Master, 12th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50014, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, 14th ed.', 'Playford 1.14',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1709,
            'The Dancing Master, 14th ed.', NULL );

INSERT INTO publication
   VALUES   ( 50015, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, Vol. II', 'Playford 2.01',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1710,
            'The Dancing Master, Vol. II', NULL );

INSERT INTO publication
   VALUES   ( 50016, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, Vol. II, 3rd ed.', 'Playford 2.03',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1718,
            'The Dancing Master, Vol. II, 3rd ed.', NULL );

INSERT INTO publication
   VALUES   ( 50017, CURRENT_TIMESTAMP, NULL,
            'The Dancing Master, Vol. III, 2nd ed.', 'Playford 3.02',
            446, 1, 1, 1, 1, NULL, NULL, 0, '', 0, 1726,
            'The Dancing Master, Vol. III, 2nd ed.', NULL );

You'll notice the 1928 edition doesn't appear, which means there was no SCD in that edition that wasn't published in an earlier edition.

These are the changes to the dance publications table:

--
--  Dance <=> Publication Map
--

ALTER TABLE dancespublicationsmap
   ADD      tag_id INTEGER;

CREATE      UNIQUE INDEX dancespublicationsmap_pk
   ON       dancespublicationsmap ( id );
--  Data fix
DELETE FROM dancespublicationsmap
   WHERE    id IN ( 22863, 16628, 16629 );
CREATE      UNIQUE INDEX dancespublicationsmap_real_pk
   ON       dancespublicationsmap ( dance_id, publication_id );
--  SELECT      dpm1.id,
--              dpm1.dance_id,
--              dpm1.publication_id,
--  			dpm1.number,
--  			dpm1.priority
--  FROM        dancespublicationsmap dpm1
--  INNER JOIN  dancespublicationsmap dpm2
--     ON       dpm1.dance_id = dpm2.dance_id
--        AND   dpm1.publication_id = dpm2.publication_id
--  	  and   dpm1.id <> dpm2.id
--  ORDER BY    dpm1.dance_id,
--              dpm1.publication_id,
--  			dpm1.id;
CREATE      INDEX dancespublicationsmap_dance_fk
   ON       dancespublicationsmap ( dance_id );
CREATE      INDEX dancespublicationsmap_publication_fk
   ON       dancespublicationsmap ( publication_id );
CREATE      INDEX dancespublicationsmap_tag_fk
   ON       dancespublicationsmap ( tag_id );

Then I was inserting links between the Playford dances and their original editions (for my
 purposes I conly cared about the first publication and not subsequent editions) using a
 python program to read a datafile and run SQL inserts:

Dance	Pub		Pge	Pty	Comment
-----	-----	---	---	---------------------------------
 1797	50001	81	0	Playford 1e	Dull Sir John
 2892	50001	91	0	Playford 1e	Hide Park
 3311	50001	53	0	Playford 1e	Jog On
 4923	50001	98	0	Playford 1e	New New Nothing
 5365	50001	57	0	Playford 1e	Prince Rupert's March
 5246	50002	112	0	Playford 4e	The Phoenix
 5789	50002	18	0	Playford 4e	Sage Leaf
 2888	50003	106	0	Playford 5e	Hey-boys Up We Go
 6108	50004	173	0	Playford 7e	Sion House
 3809	50005	216	0	Playford 8e	Lilli Burlero
 3184	50006	182	0	Playford 9e	Jacob Hall's Jigg
 3442	50006	161	0	Playford 9e	Kensington Court
 4711	50006	193	0	Playford 9e	Mr Isaac's Maggot
 4712	50006	194	0	Playford 9e	Mr Lane's Maggot
 5497	50006	177	0	Playford 9e	Red House
 2700	50007	24	0	Playford 9e p2	The Guidman of Balangigh
 2776	50007	3	0	Playford 9e p2	The Happy Marriage
 2953	50007	30	0	Playford 9e p2	Hole In The Wall
 5841	50007	5	0	Playford 9e p2	Saint Martin's Lane
 2676	50008	33	0	Playford 9e p3	Greenwich Park
 3355	50008	41	0	Playford 9e p3	The Jovial Beggars
 6083	50008	45	0	Playford 9e p3	Frae Aberdeen
 3815	50009	205	0	Playford 10e	Lincoln
 5934	50009	199	0	Playford 10e	Scotland
 1270	50011	304	0	Playford 11e	Cockle Shells
 2341	50011	266	0	Playford 11e	The French Ambassador
 3089	50011	267	0	Playford 11e	Indian Queen
 3927	50011	245	0	Playford 11e	Lord Byron's Jig
 3950	50011	273	0	Playford 11e	Lord Phoppington
 4678	50011	300	0	Playford 11e	Mother Brown's Cat
 5328	50011	243	0	Playford 11e	Portsmouth
 5716	50011	282	0	Playford 11e	The Round
 7126	50011	294	0	Playford 11e	Whitehall Minuet
  196	50012	9	0	Playford 11e p2	Apley House
 3181	50012	19	0	Playford 11e p2	Jack's Maggot
 6850	50013	343	0	Playford 12e	Up With Aily
 2792	50014	255	0	Playford 14e	The Hare's Maggot
  865	50015	178	0	Playford v2	Burgundy's Flight
 1772	50015	104	0	Playford v2	Dublin Bay 
 2012	50015	60	0	Playford v2	Ever Happy
 2741	50015	105	0	Playford v2	Hambleton's Round
 2918	50015	52	0	Playford v2	The Highland Lass
 3970	50015	166	0	Playford v2	Love's Triumph
 5113	50015	113	0	Playford v2	Orleance Baffled
 5411	50015	107	0	Playford v2	Queen Bess's Dame of Honour
 5838	50015	27	0	Playford v2	Saint Margaret's Hill
 6710	50015	142	0	Playford v2	A Trip o'er the Tweed
 6795	50015	55	0	Playford v2	Twas O'er The Hills And Far Awa
   99	50016	284	0	Playford v2	3e	All Together	One After Another
 1287	50016	209	0	Playford v2	3e	The Collier's Daughter
 3356	50016	324	0	Playford v2	3e	Joy After Sorrow
 3425	50017	82	0	Playford v3	2e	Kelsterne Gardens
 3683	50017	26	0	Playford v3	2e	Lancaster Lasses
 4861	50017	9	0	Playford v3	2e	My Lady Winwood's Maggot
 6499	50017	187	0	Playford v3	2e	Temple Bar
 7951	50017	22	0	Playford v3	2e	Smith's Round O

What all this shows is that there isn't a single Playford dance now counted as an SCD that was introduced in the 1728 edition.

Hope this helps.
  • Date  Dec. 18, 2022, 1:54 p.m.
  • User  Mark Dancer (Aelfric)
'StateBlock' object has no attribute 'is_code_block'
Well, that didn't format all that well, striped out most of the line breaks. The joys of cross platform cut and paste :)
  • Date  Dec. 18, 2022, 2:10 p.m.
  • User  Murrough Landon (murrough)
'StateBlock' object has no attribute 'is_code_block'
_Disposition_ changed to »Fixed« (previously »Needs help«)  

OK, I added an extra info note and assigned 1728 to the dance.

Mark, the emails the editors get sent in response to an issue have it as plain text. The web display uses Anselms ACE formatting, a variant of Markdown syntax. It may take a while for me to have a look at your SQL output but I will try and remember to keep the original mail which is likely to be more comprehensible.