We're using cookies to make this site more secure, featureful and efficient.

Issue 2675: Discrepancy between formation code and search description

Object
Reel of three - lead change (Formation)
Submitter
Iain Boyd
Assigned to
Eric Ferguson
Priority
Normal
Disposition
Fixed
Description
'StateBlock' object has no attribute 'is_code_block' 
There appears to be a 'discrepancy'  with the this Formation - 

Reel of three - lead change (REEL;HALF;R3;LeadChange;).

The code suggests that the Formation should be a 'half reel' whereas the searchable description suggests that Formation should be a 'full reel'!

I have not yet looked further to determine whether there are any other Formations which may be affected - such as a code for a 'full reel' or a description for a 'half reel'.

Previous Actions

  • Date  Dec. 31, 2021, 10:09 p.m.
  • User  Unknown
'StateBlock' object has no attribute 'is_code_block' 
New issue submitted
  • Date  Jan. 1, 2022, 2 a.m.
  • User  Eric Ferguson (EricFerguson)
'StateBlock' object has no attribute 'is_code_block' 
_Assigned_ changed to »EricFerguson« (previously »None«)  
_Disposition_ changed to »Fixed« (previously »New«)  

This is an obvious mistake.  I have removed the tag "HALF:"
This led me to make a wider search of discrepancies between the formation names and the formation tags. I looked at all formations concerning reels, and checked if they all had the tag "REEL:"; the tag like "R3;" indicating the type of reel; the proper tag "HALF;" (or not); the proper tag "TANDEM;" or "LEADCHANGE;" when applicable; and any other errors I saw.  I made quite a number of corrections, which I have nor registered in detail.
I expect that most of the errors have now been corrected, but I have not checked other parts of the formation list.
  • Date  Jan. 1, 2022, 2:10 a.m.
  • User  Eric Ferguson (EricFerguson)
'StateBlock' object has no attribute 'is_code_block' 
Most of the tags have been added using the "colloquial name" of the formation as starting point, as that name is commonly used when entering formations to a dance entry.    

But it is just possible that older "legacy" dances could have had the formations correctly tagged but given an erroneous "colloquial name".  Then I could have introduced new errors when changing those tags to fit that name.