Issue 2053: Publication has dances linked but is not shown as such on the web page

Object

An Introduction to Scottish Country Dancing (Publication)

Submitter

Murrough Landon (murrough)

Assigned to

Eric Ferguson

Priority

Normal

Disposition

Fixed

Description

'StateBlock' object has no attribute 'is_code_block'

In looking to see if the database has any publications without dances or tunes I found this one. I was then surprised to see the Diagrams tab was enabled.

In the editor its clear there are dances linked, but the "Has Dances" checkbox is disabled. I thought actually those flags were set automatically based on the data, perhaps overnight. Maybe thats only for Persons, not Publications? Clearly that has not happened here.

I wondered if this "no dances" state was deliberate or an oversight?

Previous Actions

Date April 18, 2020, 5:45 p.m.
User Murrough Landon (murrough)

'StateBlock' object has no attribute 'is_code_block'

New issue submitted

Date April 22, 2020, 11:09 a.m.
User Eric Ferguson (EricFerguson)

'StateBlock' object has no attribute 'is_code_block'

_Assigned_ changed to »EricFerguson« (previously »None«)  
_Disposition_ changed to »Needs help« (previously »New«)  

This is not really an "issue" concerning a SCDDB entry but it concerns the database.as a whole.  
I have "switched on" that checkbox.  The 12 dances are now visible.  
  
I do not understand what value these checkboxes add.  If they are wrongly set they block information.  What use is that?  I am not aware of any search function that uses these flags.

PROPOSAL:  EITHER "set all these checkboxes to 'On' " OR "Update every night" OR  "Eliminate them throughout SCDDB" OR "let us editors know how to make effective use of them"

In the meantime it would be worth discovering any other similar errors.

Cheers.  Eric

Date April 23, 2020, 10:25 p.m.
User Murrough Landon (murrough)

'StateBlock' object has no attribute 'is_code_block'

I imagine the Has Dances/Tunes flags are an optimisation: a quick way to tell if the software needs to make a longer database query or not. Of course this is only useful if the flag is correct.

I just made a check for other examples of this. There are a few, mostly publications with tunes. There is also one publication that really has neither dances nor tunes.

Publications wrongly marked as having no dances or tunes:  
-   261: N.tunes    1: Anniversary Book (Killeen), The  
-   330: N.tunes    2: Twizell Bridge + The King Over The Water [leaflet]  
-   339: N.tunes    1: Kerr's Collection  
-  1041: N.tunes   18: Graded and Social Dances 3 - 16 Dances  
-  1142: N.tunes    1: Heart of San Francisco, The  
-  1147: N.tunes    1: 75 Years of Dancing in St Andrews  
-  1255: N.tunes    1: Reeladelphia  
-  1273: N.dances   7: Footnotes 7  
-  1438: N.dances   1: Analysis of the London Ballroom  

Publications actually having no dances or tunes:  
-  1290: Set and Link

Total number of publications  1508  
N. wrongly flagged dances        2  
N. wrongly flagged tunes         7  
N. with no dances or tunes       1  

I will start fixing the incorrect ones.

Date April 23, 2020, 10:31 p.m.
User Murrough Landon (murrough)

'StateBlock' object has no attribute 'is_code_block'

_Disposition_ changed to »Fixed« (previously »Needs help«)  

OK, I have now fixed all the inconsistencies I found.